Add SSO_LOGIN_VANITY_URL feature ID to OIDC requests for vanity URL logins#10459
Open
AndrewAsseily wants to merge 3 commits into
Open
Add SSO_LOGIN_VANITY_URL feature ID to OIDC requests for vanity URL logins#10459AndrewAsseily wants to merge 3 commits into
AndrewAsseily wants to merge 3 commits into
Conversation
…s for vanity URL logins
ashovlin
reviewed
Jul 2, 2026
Comment on lines
+3286
to
+3290
| if self._feature_ids: | ||
| client.meta.events.register( | ||
| 'before-parameter-build.sso-oidc.*', | ||
| self._register_feature_ids, | ||
| ) |
Member
There was a problem hiding this comment.
Do we need all this plumbing of feature_ids and the event? register_feature_ids should work under the start_as_current_context in clidriver.
ashovlin
requested changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Follow-up to #10457
Description of changes: Registers the
SSO_LOGIN_VANITY_URLfeature ID in the User-Agent header on SSO-OIDC requests when the login flow resolved a vanity URL to an AWS-owned endpoint.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.